1
00:00:00,330 --> 00:00:08,400
‫We're now doing bikers file for Docker file he's on p p during the standard p p Apache and has all of

2
00:00:08,400 --> 00:00:11,460
‫his app gets in one that looks great.

3
00:00:11,460 --> 00:00:17,190
‫Also you'll notice with P HP that in order to configure different things and to add extensions in the

4
00:00:17,260 --> 00:00:20,510
‫PSP you have to use special commands in Docker.

5
00:00:20,520 --> 00:00:22,770
‫So he's doing that that's great.

6
00:00:23,410 --> 00:00:27,450
‫To add all these in I might hard code especially these libraries right here.

7
00:00:27,460 --> 00:00:32,580
‫Definitely hard code the versions because that's exactly how I got bit on my p HP production project

8
00:00:32,940 --> 00:00:39,300
‫was I think was it was you know a Postgres driver or a mongo driver or something had a bug in it and

9
00:00:39,300 --> 00:00:44,190
‫it updated to not even a major release it just updated to a minor release in one of our image builds

10
00:00:44,520 --> 00:00:57,780
‫and crashed production so definitely hard code that lets see we've got some pear stuff or pickle stuff

11
00:00:57,810 --> 00:01:04,560
‫rather we've got composed installer and it looks like you're getting whatever version there's the latest

12
00:01:04,560 --> 00:01:08,670
‫version of composer and I know lately in the last couple of years composer has been pretty rapid on

13
00:01:08,670 --> 00:01:14,580
‫the versions but I might hard code this if you're super concerned about versions I might set an enviroment

14
00:01:14,580 --> 00:01:19,060
‫variable to top to get that and then put it down here.

15
00:01:20,290 --> 00:01:22,170
‫The rest of that looks good.

16
00:01:24,560 --> 00:01:31,580
‫And then you've got down here you're setting some limits so your looks like here your hard coding stuff

17
00:01:31,580 --> 00:01:37,000
‫inside of Zend and inside of P P itself.

18
00:01:37,040 --> 00:01:39,380
‫So if you ever need to change those.

19
00:01:39,380 --> 00:01:48,230
‫Great but I find that you know sometimes in my dev environment I don't want to log these limits and

20
00:01:48,470 --> 00:01:53,450
‫settings are really high but I want them really high in production so I'll often set these as environment

21
00:01:53,450 --> 00:02:00,590
‫variables you've probably seen that in my PSP example repo and then we get down here to Drupal and we

22
00:02:00,590 --> 00:02:05,900
‫set the Drupal version and we installed Drupal so it looks like don't know if that's the end of the

23
00:02:05,900 --> 00:02:07,370
‫file or if it didn't all make it

24
00:02:11,980 --> 00:02:12,640
‫yeah.

25
00:02:12,670 --> 00:02:15,230
‫So you've got Drupal at the end there.

26
00:02:15,250 --> 00:02:19,630
‫I would take that as Drupal versions throw them all the way to the top right below the from that.

27
00:02:19,630 --> 00:02:22,810
‫That way I know what all versions I'm installing and that does.

28
00:02:22,810 --> 00:02:25,720
‫I keep those at the top it's easier to read when they're all the way at the top.

29
00:02:25,720 --> 00:02:30,100
‫At first it always makes sense to put the version with the block that you're using it in but as you

30
00:02:30,100 --> 00:02:34,160
‫get more and more versions of things like versions of composer version of Drupal all that stuff.

31
00:02:34,230 --> 00:02:34,480
‫Yeah

32
00:02:37,400 --> 00:02:38,200
‫cool stuff.

33
00:02:38,240 --> 00:02:38,900
‫And so yeah.

34
00:02:38,930 --> 00:02:40,250
‫And you're doing the curl right.

35
00:02:40,250 --> 00:02:43,290
‫All here you're cleaning up after yourself.

36
00:02:43,370 --> 00:02:47,810
‫It looks great it looks great there and you're choking as usual.

37
00:02:47,810 --> 00:02:51,980
‫We got a show on our directories and good stuff.

38
00:02:51,980 --> 00:02:53,990
‫I think overall this is a great doctor file.

39
00:02:53,990 --> 00:02:56,020
‫It's got a lot going on.

40
00:02:56,420 --> 00:03:00,770
‫I don't know if you've considered separating out Dev dependencies from production dependencies if you

41
00:03:00,770 --> 00:03:01,800
‫have to deal with that.

42
00:03:01,910 --> 00:03:06,690
‫You might consider multi-stage in order to do that in production.

43
00:03:06,830 --> 00:03:08,770
‫But other than that it looks legit.

44
00:03:08,870 --> 00:03:09,230
‫Catch up.