‫We're now doing bikers file for Docker file he's on p p during the standard p p Apache and has all of
‫his app gets in one that looks great.
‫Also you'll notice with P HP that in order to configure different things and to add extensions in the
‫PSP you have to use special commands in Docker.
‫So he's doing that that's great.
‫To add all these in I might hard code especially these libraries right here.
‫Definitely hard code the versions because that's exactly how I got bit on my p HP production project
‫was I think was it was you know a Postgres driver or a mongo driver or something had a bug in it and
‫it updated to not even a major release it just updated to a minor release in one of our image builds
‫and crashed production so definitely hard code that lets see we've got some pear stuff or pickle stuff
‫rather we've got composed installer and it looks like you're getting whatever version there's the latest
‫version of composer and I know lately in the last couple of years composer has been pretty rapid on
‫the versions but I might hard code this if you're super concerned about versions I might set an enviroment
‫variable to top to get that and then put it down here.
‫The rest of that looks good.
‫And then you've got down here you're setting some limits so your looks like here your hard coding stuff
‫inside of Zend and inside of P P itself.
‫So if you ever need to change those.
‫Great but I find that you know sometimes in my dev environment I don't want to log these limits and
‫settings are really high but I want them really high in production so I'll often set these as environment
‫variables you've probably seen that in my PSP example repo and then we get down here to Drupal and we
‫set the Drupal version and we installed Drupal so it looks like don't know if that's the end of the
‫file or if it didn't all make it
‫yeah.
‫So you've got Drupal at the end there.
‫I would take that as Drupal versions throw them all the way to the top right below the from that.
‫That way I know what all versions I'm installing and that does.
‫I keep those at the top it's easier to read when they're all the way at the top.
‫At first it always makes sense to put the version with the block that you're using it in but as you
‫get more and more versions of things like versions of composer version of Drupal all that stuff.
‫Yeah
‫cool stuff.
‫And so yeah.
‫And you're doing the curl right.
‫All here you're cleaning up after yourself.
‫It looks great it looks great there and you're choking as usual.
‫We got a show on our directories and good stuff.
‫I think overall this is a great doctor file.
‫It's got a lot going on.
‫I don't know if you've considered separating out Dev dependencies from production dependencies if you
‫have to deal with that.
‫You might consider multi-stage in order to do that in production.
‫But other than that it looks legit.
‫Catch up.